xmlsecurity: XSecParser confused about multiple timestamps
authorMichael Stahl <michael.stahl@allotropia.de>
Thu, 18 Feb 2021 18:22:31 +0000 (19:22 +0100)
committerRene Engelhard <rene@debian.org>
Sun, 10 Oct 2021 10:37:28 +0000 (11:37 +0100)
commit179d75fc263de8bfc6bfe70f9a3715cbd5a03247
tree6a7bb7beeff84267adb2cc034a83806077107f61
parent57d727c57711c6e8254d31e059a4787e4955bdb1
xmlsecurity: XSecParser confused about multiple timestamps

LO writes timestamp both to dc:date and xades:SigningTime elements.

The parser tries to avoid reading multiple dc:date, preferring the first
one, but doesn't care about multiple xades:SigningTime, for undocumented
reasons.

Ideally something should check all read values for consistency.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111160
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 4ab8d9c09a5873ca0aea56dafa1ab34758d52ef7)

xmlsecurity: remove XSecController::setPropertyId()

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111252
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit d2a345e1163616fe3201ef1d6c758e2e819214e0)

Change-Id: Ic018ee89797a1c8a4f870ae102af48006de930ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111908
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Gbp-Pq: Name xmlsecurity-XSecParser-confused-about-multiple-timestamps.diff
include/svl/sigstruct.hxx
xmlsecurity/inc/xsecctl.hxx
xmlsecurity/source/helper/ooxmlsecparser.cxx
xmlsecurity/source/helper/xsecctl.cxx
xmlsecurity/source/helper/xsecparser.cxx
xmlsecurity/source/helper/xsecparser.hxx
xmlsecurity/source/helper/xsecsign.cxx
xmlsecurity/source/helper/xsecverify.cxx